Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the usage protobuf API surface to support usage-based alerting rules, including rule metadata, configuration, status, and basic CRUD request/response messages.
Changes:
- Added new usage alerting rule protos (
UsageAlertingRule, metadata/config/status, andUsageAlertingWindowenum) toproto/usage.proto. - Added request/response messages for listing, creating, and deleting usage alerting rules.
- Updated Bazel proto build targets to include new proto dependencies (user ID + timestamp) for
usageproto generation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
proto/usage.proto |
Adds message/enum definitions and RPC message shapes for usage alerting rules, including timestamps and creator identity. |
proto/BUILD |
Wires in user_id and timestamp deps for proto / TS / Go generation of the updated usage protos. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bduffany
force-pushed
the
usage-alerts-proto
branch
3 times, most recently
from
8bf8ad2 to
080e97e
Compare
maggie-lou
reviewed
Apr 29, 2026
bduffany
force-pushed
the
usage-alerts-proto
branch
from
080e97e to
6d80add
Compare
maggie-lou
approved these changes
Apr 30, 2026
Member
Author
|
Gonna go ahead and merge so that I can start implementing the BE/FE on top of this. Feel free to review still, and I can address in follow-ups |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds protos for basic usage alerting. For v0, I'm thinking the system can look something close to this:
* Only adding Create, List, and Delete APIs for now. "Update" can be done by deleting and recreating a rule (could maybe add a "clone" button in the UI to make it slightly less tedious, or implement Update later if we have a need)
** If the cronjob fails between steps 3 and 4, we may send duplicate alerts (at-least-once semantics). As a "nice to have," if we choose an email delivery provider that supports idempotency keys, then we can get exactly-once delivery semantics.